feat(onboarding) - remove versioning #721
Conversation
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (281 total)
✅ Bundle size check passed |
|
Deploy preview for remote-flows ready! ✅ Preview Built with commit c83483e. |
|
Deploy preview for remote-flows-example-app ready! ✅ Preview Built with commit c83483e. |
|
npm warn exec The following package was not found and will be installed: tsx@4.21.0 📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 87.58% | 87.63% | -0.05% | 🔴 |
| Statements | 87.21% | 87.26% | -0.05% | 🔴 |
| Functions | 83.17% | 83.18% | -0.02% | 🔴 |
| Branches | 79.24% | 79.33% | -0.10% | 🔴 |
Detailed Breakdown
Lines Coverage
- Covered: 2885 / 3294
- Coverage: 87.58%
- Change: -0.05% (-13 lines)
Statements Coverage
- Covered: 2939 / 3370
- Coverage: 87.21%
- Change: -0.05% (-14 statements)
Functions Coverage
- Covered: 825 / 992
- Coverage: 83.17%
- Change: -0.02% (-1 functions)
Branches Coverage
- Covered: 1847 / 2331
- Coverage: 79.24%
- Change: -0.10% (-11 branches)
✅ Coverage check passed
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| * Defines allowed JSON schema versions per country for contract_details | ||
| * Key: country code, Value: array of allowed versions (first is default/recommended) | ||
| */ | ||
| const COUNTRY_CONTRACT_DETAILS_VERSION_ALLOWLIST: Record<string, number[]> = { |
There was a problem hiding this comment.
This i think you still need no? it happens to be the same as default version for DEU, so it should not matter, but just to clarify, we might still have a default version from the sdk that is different per country, right?
There was a problem hiding this comment.
I don't understand, the recommended version is the 1 one for all countries
I understand in the future there could be recommended versions by each country, we can do that later as now all countries are on 1
cammellos
left a comment
cammellos
left a comment
There was a problem hiding this comment.
to check with bamboohr before merging, but otherwise looks good
We remove the whitelisting to allow update to whatever version
Note
Medium Risk
Moderate risk because schema-version validation is removed (potentially requesting unsupported schema versions) and generated SDK surface area changes could affect downstream consumers relying on strict types.
Overview
Onboarding schema version handling is loosened:
contract_detailsschema version selection no longer validates against a per-country allowlist, and version parameters are widened to acceptnumber | 'latest'(includingjsonSchemaVersionByCountryand related hooks/API calls). Tests and utilities are updated accordingly by removing the now-invalid allowlist/validation expectations.The generated API client is expanded with SCIM v2 support by adding
GET /scim/v2/Users,GET /scim/v2/Users/{id},GET /scim/v2/Groups, andGET /scim/v2/Groups/{id}plus their corresponding types. It also updates several schema-version query params to accept'latest'and adds anexclude_filesquery option togetShowEmployment.Written by Cursor Bugbot for commit ba9f915. This will update automatically on new commits. Configure here.